Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new official MSSQL docker image #3166

Merged
merged 2 commits into from
Jul 1, 2021
Merged

Use the new official MSSQL docker image #3166

merged 2 commits into from
Jul 1, 2021

Conversation

chrzaszcz
Copy link
Member

@codecov
Copy link

codecov bot commented Jul 1, 2021 •
edited
Loading

Codecov Report

Merging #3166 (63d802d) into master (20480a5) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3166      +/-   ##
==========================================
+ Coverage   79.91%   80.24%   +0.32%     
==========================================
  Files         396      396              
  Lines       32260    32260              
==========================================
+ Hits        25781    25886     +105     
+ Misses       6479     6374     -105
Impacted Files Coverage Δ
src/cassandra/mongoose_cassandra_worker.erl 70.75% <0.00%> (-2.36%) ⬇️
src/http_upload/mod_http_upload.erl 94.56% <0.00%> (-2.18%) ⬇️
src/ejabberd_s2s_out.erl 60.13% <0.00%> (-1.83%) ⬇️
src/domain/service_domain_db.erl 78.12% <0.00%> (-1.57%) ⬇️
...c/global_distrib/mod_global_distrib_server_mgr.erl 76.27% <0.00%> (-0.57%) ⬇️
src/ejabberd_c2s.erl 89.05% <0.00%> (-0.23%) ⬇️
src/pubsub/mod_pubsub.erl 73.17% <0.00%> (-0.06%) ⬇️
src/mod_muc_log.erl 77.77% <0.00%> (ø)
src/mod_muc_room.erl 77.10% <0.00%> (+0.17%) ⬆️
src/pubsub/mod_pubsub_db_rdbms.erl 95.34% <0.00%> (+0.25%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20480a5...63d802d. Read the comment docs.

NelsonVides
NelsonVides approved these changes Jul 1, 2021
View reviewed changes
Copy link
Collaborator

@NelsonVides NelsonVides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, thanks! 🎉

@NelsonVides NelsonVides merged commit 45c3308 into master Jul 1, 2021
@NelsonVides NelsonVides deleted the fix-mssql branch July 1, 2021 12:24
@Premwoik Premwoik added this to the 5.0.0 milestone Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NelsonVides NelsonVides NelsonVides approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chrzaszcz @NelsonVides @Premwoik